Fix tsdelay and troff #367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SMPTE ST 2110-21:2022: TROFF shall be a positive number or zero
…s which are using the optional tsdelay and troff
garethsb
reviewed
Feb 5, 2024
garethsb
reviewed
Feb 5, 2024
| @@ -600,11 +576,11 @@ BST_TEST_CASE(testSdpParametersVideoRaw) | |||
| { U("PM"), U("2110BPM") }, | |||
| { U("SSN"), U("ST2110-20:2022") }, | |||
| { U("TP"), U("2110TPW") }, | |||
| { U("TROFF"), U("37") }, | |||
| { U("TROFF"), U("0") }, | |||
There was a problem hiding this comment.
Not sure if we should have these zeros as a separate test case?
There was a problem hiding this comment.
Will add new test for zero troff and tsdelay
There was a problem hiding this comment.
Added test for zero troff and tsdelay
garethsb
reviewed
Feb 5, 2024
| @@ -622,20 +598,20 @@ BST_TEST_CASE(testSdpParametersVideoRaw) | |||
| sdp::packing_modes::block, | |||
| sdp::smpte_standard_numbers::ST2110_20_2022, | |||
| sdp::type_parameters::type_W, | |||
| 37, | |||
| uint32_t(0), | |||
There was a problem hiding this comment.
Out of interest, does a bare 0 work? Or 0U? Bare 37 or 82 used to work...
There was a problem hiding this comment.
Ubuntu 14.04 issue again GCC 4.8.4 compile error, when using bare 0 for the bst::optional parameters. Maybe 0U will work.
garethsb
reviewed
Feb 5, 2024
garethsb
reviewed
Feb 5, 2024
garethsb
reviewed
Feb 5, 2024
garethsb
reviewed
Feb 5, 2024
Co-authored-by: Gareth Sylvester-Bradley <[email protected]>
garethsb
reviewed
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SMPTE ST 2110-10:2022:
TSDELAY shall be a positive number or zeroSee SMPTE ST 2110-10:2022 Professional Media over Managed IP Networks: System Timing and Definitions, Annex B SDP Example (Informative)
SMPTE ST 2110-21:2022:
TROFF shall be a positive number or zeroSee SMPTE ST 2110-21:2022 Professional Media over Managed IP Networks: Traffic Shaping and Delivery Timing for Video, Section 6.2 Virtual Receiver Buffer Packet Read Schedule (PRS) Parameters